Fix Monaco IOS keyboard button#24341
Merged
silverwind merged 7 commits intogo-gitea:mainfrom Apr 26, 2023
Merged
Conversation
GiteaBot
added
the
lgtm/need 2
silverwind
added
the
outdated/backport/v1.19
wxiaoguang
approved these changes
Apr 26, 2023
Contributor
wxiaoguang
left a comment
wxiaoguang
left a comment
There was a problem hiding this comment.
Do we know which Fomantic class destroys it?
GiteaBot
added
lgtm/need 1
techknowlogick
approved these changes
Apr 26, 2023
GiteaBot
added
lgtm/done
techknowlogick
added
the
reviewed/wait-merge
Member
Author
Was something like |
GiteaBot
added a commit
to GiteaBot/gitea
that referenced
this pull request
Apr 26, 2023
Fix go-gitea#16188. Turns out the element was completely misaligned by fomantic styles. Add most of the original styles in `!important` form to fix. Tapping the button doesn't do anything useful in Simulator.app, but I guess it's still better to not outright hide it in case it has a possiblity to work. <img width="121" alt="image" src="https://user-images.githubusercontent.com/115237/234379685-4e67f8cd-7e91-4bcc-8e17-9d5b2ebed6cd.png"> Co-authored-by: Giteabot <teabot@gitea.io>
GiteaBot
added
backport/done
Contributor
I guess we need a detailed comment for it...... |
Member
Author
|
Maybe later. If you wanna check it out yourself, install XCode, then |
silverwind
added a commit
that referenced
this pull request
Apr 26, 2023
Backport #24341 by @silverwind Fix #16188. Turns out the element was completely misaligned by fomantic styles. Add most of the original styles in `!important` form to fix. Tapping the button doesn't do anything useful in Simulator.app, but I guess it's still better to not outright hide it in case it has a possiblity to work. <img width="121" alt="image" src="https://user-images.githubusercontent.com/115237/234379685-4e67f8cd-7e91-4bcc-8e17-9d5b2ebed6cd.png"> Co-authored-by: silverwind <me@silverwind.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #16188. Turns out the element was completely misaligned by fomantic styles. Add most of the original styles in
!importantform to fix.Tapping the button doesn't do anything useful in Simulator.app, but I guess it's still better to not outright hide it in case it has a possiblity to work.